Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use obvious fake path in example #324

Merged
merged 2 commits into from
Dec 10, 2024
Merged

use obvious fake path in example #324

merged 2 commits into from
Dec 10, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Dec 9, 2024

in particular, as suggested by #322 (comment)

@jdhoffa should we leave #322 open as a suggestion to include a recommendation of setting up a new RStudio project?

- closes #322 (maybe)

in particular, as suggested by #322 (comment)

@jdhoffa should we leave #322 open as a suggestion to include a recommendation of setting up a new RStudio project?
@cjyetman cjyetman requested a review from jacobvjk as a code owner December 9, 2024 15:19
@cjyetman cjyetman requested a review from jdhoffa December 9, 2024 15:19
Copy link

github-actions bot commented Dec 9, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-10 08:52 UTC

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (e270fc3) to head (f8b296a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   51.82%   51.82%           
=======================================
  Files          29       29           
  Lines        3178     3178           
=======================================
  Hits         1647     1647           
  Misses       1531     1531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdhoffa
Copy link
Member

jdhoffa commented Dec 9, 2024

in particular, as suggested by #322 (comment)

@jdhoffa should we leave #322 open as a suggestion to include a recommendation of setting up a new RStudio project?

No, I think this supersedes/ addresses the intent of #322

@cjyetman cjyetman merged commit 7bb7aa1 into main Dec 10, 2024
11 checks passed
@cjyetman cjyetman deleted the use-fake-path-in-example branch December 10, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: in project setup, we may want to document that the user should start a new RStudio project
3 participants