Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grammar fixes in cookbook analysis #301

Merged
merged 9 commits into from
Dec 9, 2024
Merged

grammar fixes in cookbook analysis #301

merged 9 commits into from
Dec 9, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Dec 6, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (83842f2) to head (919e369).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   51.82%   51.82%           
=======================================
  Files          29       29           
  Lines        3178     3178           
=======================================
  Hits         1647     1647           
  Misses       1531     1531

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-09 15:00 UTC

@cjyetman cjyetman marked this pull request as ready for review December 9, 2024 13:35
@cjyetman cjyetman requested a review from jacobvjk as a code owner December 9, 2024 13:35
@cjyetman
Copy link
Member Author

cjyetman commented Dec 9, 2024

@jdhoffa @jacobvjk finished reviewing and making edits to the analysis doc

added a few inline notes to point out what/why I changed

@cjyetman cjyetman requested a review from jdhoffa December 9, 2024 13:36
jacobvjk
jacobvjk approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vignettes/cookbook_running_the_analysis.Rmd Outdated Show resolved Hide resolved
@cjyetman cjyetman merged commit e270fc3 into main Dec 9, 2024
11 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-6 branch December 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjyetman @jdhoffa @jacobvjk