-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add different install instructions for release and dev #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to test if the ::: {.pkgdown-release}
chunks render without seeing it on pkgdown
, but I'll take your word!
The README.md
does not seem to render as expected though.
one can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 49.00% 49.00%
=======================================
Files 28 28
Lines 3253 3253
=======================================
Hits 1594 1594
Misses 1659 1659 ☔ View full report in Codecov by Sentry. |
README.md
with CRAN installation instructions #210 very easily once it's released on CRAN (by simply removing the comment fences)note: also removes the text saying which repo
install.packages()
installs from, which technically can not be know since it's dependent on the user's setupnote: also removes the text about verifying the install with
library(pacta.multi.loanbook)
because I don't think that makes much sense nor is it really a great way to actually verify install