Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add different install instructions for release and dev #235

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Nov 13, 2024

note: also removes the text saying which repo install.packages() installs from, which technically can not be know since it's dependent on the user's setup

note: also removes the text about verifying the install with library(pacta.multi.loanbook) because I don't think that makes much sense nor is it really a great way to actually verify install

@cjyetman cjyetman requested a review from jacobvjk as a code owner November 13, 2024 12:49
@cjyetman cjyetman requested a review from jdhoffa November 13, 2024 12:49
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard for me to test if the ::: {.pkgdown-release} chunks render without seeing it on pkgdown, but I'll take your word!

The README.md does not seem to render as expected though.

README.md Outdated Show resolved Hide resolved
@cjyetman
Copy link
Member Author

It's hard for me to test if the ::: {.pkgdown-release} chunks render without seeing it on pkgdown, but I'll take your word!

The README.md does not seem to render as expected though.

one can run pkgdown::build_site() to see the result locally

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (18c7df7) to head (8d4ee50).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   49.00%   49.00%           
=======================================
  Files          28       28           
  Lines        3253     3253           
=======================================
  Hits         1594     1594           
  Misses       1659     1659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjyetman cjyetman merged commit db21291 into main Nov 15, 2024
11 checks passed
@cjyetman cjyetman deleted the release-and-dev-install-instructions branch November 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Remove CRAN installation instructions until it is actually on CRAN
3 participants