Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 calculate match success rate #17

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Conversation

jacobvjk
Copy link
Member

@jacobvjk jacobvjk commented Apr 3, 2024

closes #12

  • workflow.multi.loanbook gains script run_calculate_match_success_rate.R, which calculates the match success rates in terms of...
    • matched number of loans and matched loan size
    • both in absolute and relative terms
    • for individual loan books and the meta loan book
    • and produces plots using plot_match_success_rate()
  • gains plots.R which contains the relevant plotting function
  • gains additional parameters documented in example.config.yml that allow adjusting the output format of the plots
  • updates object names in expected_columns.R to better match their usage and updates the relevant scripts accordingly (this could have been a separate issue but given the change is very small I opted to include it here)

NOTE: plot_match_success_rate() should be moved to pacta.multi.loanbook.plot or r2dii.plot at some point and exported (see RMI-PACTA/r2dii.plot#563)

@jacobvjk jacobvjk marked this pull request as ready for review April 3, 2024 15:01
@jacobvjk jacobvjk requested a review from jdhoffa April 3, 2024 15:01
plots.R Outdated Show resolved Hide resolved
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jacobvjk jacobvjk merged commit 74de412 into main Apr 4, 2024
@jacobvjk jacobvjk deleted the 12-calculate-match-success-rate branch April 4, 2024 08:28
@MonikaFu
Copy link

MonikaFu commented Apr 4, 2024

Sounds like something that should live in r2dii.plot since it is relevant also for non-multi users, right? Happy to work on it when I get a mandate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: calculate match success rate
3 participants