Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prepared abcd in matching #153

Merged
merged 3 commits into from
Sep 23, 2024
Merged

use prepared abcd in matching #153

merged 3 commits into from
Sep 23, 2024

Conversation

jacobvjk
Copy link
Member

closes #14

  • run_matching() and run_match_prioritize() now both use the abcd_final.csv as input for the abcd, instead of the raw abcd file
  • this means that abcd_final now simply has to be prepared once using prepare_abcd() as the very first step of the analysis and all following functions expect that same data set
  • this is a prerequisite for implementing the information architecture as agreed upon in https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11852

@jacobvjk jacobvjk requested a review from cjyetman September 23, 2024 09:57
R/run_match_prioritize.R Outdated Show resolved Hide resolved
jacobvjk and others added 2 commits September 23, 2024 12:16
@jacobvjk jacobvjk merged commit 9ba41a9 into main Sep 23, 2024
9 checks passed
@jacobvjk jacobvjk deleted the use-abcd-final-for-matching branch September 23, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't you use the "prepared" abcd for matching?
2 participants