Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review and align variable and function naming repo-wide #54

Closed
cjyetman opened this issue Aug 14, 2024 · 1 comment · Fixed by #226
Closed

review and align variable and function naming repo-wide #54

cjyetman opened this issue Aug 14, 2024 · 1 comment · Fixed by #226
Assignees
@cjyetman
Labels
upkeep maintenance, infrastructure, and similar

Comments

@cjyetman
Copy link
Member

cjyetman commented Aug 14, 2024 •
edited
Loading

nit: I have renamed some of the objects created from the confg in the other scripts, basically stripping the prefix input_. s anything that is a full path to a file is path_* <- x/y.ext and anything that is a directory is dir_* <- x/y. Not technically necessary to merge this, but maybe a good idea to use one style across the scripts.

Originally posted by @jacobvjk in #48 (comment)
@cjyetman cjyetman mentioned this issue Aug 14, 2024
Merged
@cjyetman cjyetman changed the title review and align variable naming repo-wide review and align variable and function naming repo-wide Aug 19, 2024
@cjyetman cjyetman mentioned this issue Aug 19, 2024
Merged
@cjyetman
Copy link
Member Author

cjyetman commented Nov 7, 2024

@jdhoffa @jacobvjk I believe this is still relevant, but it would be a nice-to-have to ease development and understanding of the code, not a critical task.

@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label Nov 7, 2024
@jdhoffa jdhoffa mentioned this issue Nov 7, 2024
Closed
@cjyetman cjyetman self-assigned this Nov 8, 2024
@cjyetman cjyetman mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjyetman cjyetman

Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

align variable names (and related function and parameter names) RMI-PACTA/pacta.multi.loanbook
2 participants
@cjyetman @jdhoffa