Config loading utils #69
Conversation
| params[["project_parameters"]][["region_select"]] | ||
| } | ||
|
|
||
| get_aggregate_alignment_metric_by_group <- function(params) { |
There was a problem hiding this comment.
this will have to be renamed once we tackle the more generalized grouping across the modules. but fine for now
| config_prepare_sector_split$filename_advanced_company_indicators | ||
| ) | ||
| dir_matched <- get_matched_dir(config) | ||
| abcd_dir <- get_abcd_dir(config) |
There was a problem hiding this comment.
nit: naming convention seems to be inversed. should be dir_abcd
There was a problem hiding this comment.
yeah, it's a bit mixed throughout the code... maybe I introduced that when I ported some scripts over. I was going for most-specific-first because it feels easier and faster to understand what you're looking at, especially when the names get really long. That might be a English-as-first-language bias though.
There was a problem hiding this comment.
let's discuss naming conventions on Wednesday and then implement everywhere
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd like to join the naming convention call too!
|
|
||
| dir_matched <- config_dir$dir_matched | ||
| abcd_dir <- get_abcd_dir(config) |
No description provided.