Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't you use the "prepared" abcd for matching? #14

Closed
jacobvjk opened this issue Apr 3, 2024 · 0 comments · Fixed by #153
Closed

Shouldn't you use the "prepared" abcd for matching? #14

jacobvjk opened this issue Apr 3, 2024 · 0 comments · Fixed by #153
Labels
ADO send issue to ADO feature a feature request or enhancement

Comments

@jacobvjk
Copy link
Member

jacobvjk commented Apr 3, 2024

          Shouldn't you use the "prepared" abcd for matching? 

If we are potentially removing inactive companies anyway, it could lead to a slightly easier matching process.

Originally posted by @jdhoffa in #8 (comment)

AB#10475

Advantage would be to slightly improve matching performance and use one consistent ABCD data set throughout the analysis.

Drawback is that the removal of inactive companies is only needed for aggregate metrics, not standard PACTA and applying the prep/removal will add an unnecessary step for standard PACTA potentially reducing the match success rate.

@jacobvjk jacobvjk added feature a feature request or enhancement ADO send issue to ADO labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO send issue to ADO feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant