Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/41 check for empty downloads #44

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Conversation

AlexAxthelm
Copy link
Contributor

Add checks that data pulled from sources is not empty

Closes #41

@AlexAxthelm AlexAxthelm requested a review from cjyetman as a code owner April 18, 2024 16:49
@AlexAxthelm AlexAxthelm requested a review from jdhoffa April 18, 2024 16:50
jdhoffa
jdhoffa previously approved these changes Apr 19, 2024
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cjyetman
Copy link
Member

I forgot that I am the maintainer of this repo now 🤣
I'll take a look at this tomorrow.

R/get_index_regions.R Outdated Show resolved Hide resolved
R/get_index_regions.R Outdated Show resolved Hide resolved
@cjyetman cjyetman merged commit 847dd09 into main Apr 23, 2024
7 checks passed
@cjyetman cjyetman deleted the feat/41-check-for-empty-downloads branch April 23, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_ishares_index_data() continues without error while returning an empty table
3 participants