Wire up company page #70
Conversation
…to wire-up-company-page
| { | ||
| "id": "Nissan Motor Co., Ltd.", | ||
| "id": "Hyundai Motor Co., Ltd.", | ||
| "ald_sector": "Automotive", | ||
| "technology": "Electric", | ||
| "plan_tech_share": 0.207746608894222, | ||
| "port_weight": 0.00761768898721195, | ||
| "scenario": "NZE 2050", | ||
| "plan_tech_share": 0.1927, | ||
| "port_weight": 0.1156, | ||
| "allocation": "portfolio_weight", | ||
| "scenario_source": "WEO2023", | ||
| "scenario": "APS", | ||
| "year": 2028, | ||
| "asset_class": "Listed Equity", | ||
| "ald_sector_translation": "Automotive", | ||
| "asset_class_translation": "Listed Equity", | ||
| "technology_translation": "LDV: Electric" | ||
| }, |
There was a problem hiding this comment.
Hyundai appears to be accurately classed as an Automotive company in the data here?
|
@MonikaFu I believe the data is correct. In the (test) data, Hyundai is classed as both an Automotive Company and a Power company, when using the In E.g. |
|
I am curious however why "Hyundai" isn't appearing in the company data plots for the Automotive sector? There is relevant data there, so I am surprised to not see a corresponding plot. |
|
thanks @jdhoffa . Then indeed in this case it is not incorrect that automotive companies appear in power sector. It was strange to me to see them in power but not in automotive, that's why I thought it is a problem in the data. It still feels strange that they don't appear in the plots for automotive |
Data not appearing in the plots for Automotive feels like a problem that should be tackled in this PR actually! Or at least assessed to understand why they aren't showing up |
|
@jdhoffa you are right, I was confused because of the data for Auto showing in Power. I somewhat assumed the data must be wrong. After closer inspection I found a bug in my implementation. I fixed it and added a check to prevent it in the future. |
NOTE: the data seems to be off. It shows no data for Automotive for techmix plot but then the power company names seem to be automotive names. Also, for techmix there exist only data for ownership weights for listed equity. I added two issues in
workflow.pacta.dashboard: RMI-PACTA/workflow.pacta.dashboard#23 and RMI-PACTA/workflow.pacta.dashboard#22. But also we should look into the test data. Since the issues seem to be connected the data and not the workings of the dashboard, I consider this PR ready for review.