Audit Log API Layer #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcspragu
approved these changes
Dec 29, 2023
Comment on lines
+111
to
+153
| result := &db.AuditLogQueryWhere{} | ||
| if i.InId != nil { | ||
| result.InID = fromStrs[pacta.AuditLogID](*i.InId) | ||
| } | ||
| if i.MinCreatedAt != nil { | ||
| result.MinCreatedAt = *i.MinCreatedAt | ||
| } | ||
| if i.MaxCreatedAt != nil { | ||
| result.MaxCreatedAt = *i.MaxCreatedAt | ||
| } | ||
| if i.InAction != nil { | ||
| as, err := convAll(*i.InAction, auditLogActionFromOAPI) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("converting audit log query where in action: %w", err) | ||
| } | ||
| result.InAction = as | ||
| } | ||
| if i.InActorType != nil { | ||
| at, err := convAll(*i.InActorType, auditLogActorTypeFromOAPI) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("converting audit log query where in actor type: %w", err) | ||
| } | ||
| result.InActorType = at | ||
| } | ||
| if i.InActorId != nil { | ||
| result.InActorID = *i.InActorId | ||
| } | ||
| if i.InActorOwnerId != nil { | ||
| result.InActorOwnerID = fromStrs[pacta.OwnerID](*i.InActorOwnerId) | ||
| } | ||
| if i.InTargetType != nil { | ||
| tt, err := convAll(*i.InTargetType, auditLogTargetTypeFromOAPI) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("converting audit log query where in target type: %w", err) | ||
| } | ||
| result.InTargetType = tt | ||
| } | ||
| if i.InTargetId != nil { | ||
| result.InTargetID = *i.InTargetId | ||
| } | ||
| if i.InTargetOwnerId != nil { | ||
| result.InTargetOwnerID = fromStrs[pacta.OwnerID](*i.InTargetOwnerId) | ||
| } |
There was a problem hiding this comment.
Did RMI ask for any/all of this functionality? Seems like a lot of ways to slice and dice stuff out of the gate, versus just the MVP.
There was a problem hiding this comment.
I had a long convo with Hodie about this early in the project. My recollection is that the goal was to make audit logs useful for debuging + analytics, in addition to serving their purpose of giving folks confidence in the data handling practices.
There was a problem hiding this comment.
Another benefit is that the API exposed maps cleanly onto the PV Pagination Table interface (sorting, filtering etc) so building a maintainable frontend for this is going to be delightfully easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActorTypeto refer to the pathway through which the user is accessing, rather than the property of the user. This unfortunately required a DB migration to add the new enum values.ParseSortBymethod to the DB Layer.