Serialize errors we encounter #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcspragu
force-pushed
the
brandon/reorder
branch
from
da66f6e to
247dfc1
Compare
bcspragu
force-pushed
the
brandon/serial
branch
from
90e3cc6 to
51d3b95
Compare
gbdubs
approved these changes
Nov 17, 2023
This PR makes it so that we serialize errors if we're going to send them across the SSR boundary. The problem this fixes is that some errors (like Nuxt reporting composable usage outside a `setup` function) have functions and other non-POJO/non-serializable info with them, which makes our `useState<Error>` implode, ironically hiding the original error. This introduces a new non-dev dependency (which I don't do lightly) on `serialize-error`, a small (<1kB min + gzip'd) and popular dependency for doing the surprisingly nontrivial task of serializing different types of errors and preserving type information.
bcspragu
force-pushed
the
brandon/serial
branch
from
51d3b95 to
0d276f8
Compare
Most definitely! I want to let it marinade here a bit to make sure it does what I hope it will do in a variety of use cases (including trying to render specific errors based on type on the client after hydration), but we'll see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we serialize errors if we're going to send them across the SSR boundary. The problem this fixes is that some errors (like Nuxt reporting composable usage outside a
setupfunction) have functions and other non-POJO/non-serializable info with them, which makes ouruseState<Error>implode, ironically hiding the original error.This introduces a new non-dev dependency (which I don't do lightly) on
serialize-error, a small (<1kB min + gzip'd) and popular dependency for doing the surprisingly nontrivial task of serializing different types of errors and preserving type information.