Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames "process" step to "parse" #60

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Renames "process" step to "parse" #60

merged 2 commits into from
Nov 17, 2023

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Nov 16, 2023 •
edited
Loading

I'll wait to confirm https://github.com/RMI/terraform/pull/18 is complete before submitting.

@gbdubs gbdubs requested a review from bcspragu November 16, 2023 02:06
bcspragu
bcspragu approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@bcspragu bcspragu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but yeah, also update the Terraform (resource names, webhook path, etc) or this will totally not work.

azure/azevents/azevents.go Show resolved Hide resolved
cmd/runner/main.go Outdated Show resolved Hide resolved
@gbdubs gbdubs merged commit ff249c9 into main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcspragu bcspragu bcspragu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbdubs @bcspragu