Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardizes YAML Formatting #59

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Standardizes YAML Formatting #59

merged 1 commit into from
Nov 15, 2023

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Nov 15, 2023

Runs google/yamlfmt over our openapi definitions.

@gbdubs gbdubs requested a review from bcspragu November 15, 2023 15:20
bcspragu
bcspragu approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@bcspragu bcspragu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any interest in checking for bad formatting as part of CI? I wouldn't spend more than ~10 minutes on it though

@gbdubs
Copy link
Contributor Author

gbdubs commented Nov 15, 2023

Spent more than 10m. Calling it. I think we can just do this from time to time - drift here is of minimal importance.

@gbdubs gbdubs merged commit 675275b into main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcspragu bcspragu bcspragu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbdubs @bcspragu