Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Event Grid event from runner after processing portfolio #49

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

bcspragu
Copy link
Collaborator

@bcspragu bcspragu commented Nov 1, 2023

This PR adds support for sending 'processed-portfolio' notifications from the runner, and receiving/parsing them in pactasrv.

While Azure requires validating a webhook endpoint when you add it, it doesn't provide validation on each individual webhook request, so the next PR will contain basic shared secret authentication to avoid The Internet At Large from curl-ing /events/processed-portfolio.

This PR adds support for sending 'processed-portfolio' notifications from the runner, and receiving/parsing them in `pactasrv`.

While Azure requires validating a webhook endpoint when you add it, it _doesn't_ provide validation on each individual webhook request, so the next PR will contain basic shared secret authentication to avoid The Internet At Large from `curl`-ing `/events/processed-portfolio`.
@bcspragu bcspragu requested a review from gbdubs November 1, 2023 21:02
@bcspragu bcspragu merged commit 6a6dc1e into main Nov 1, 2023
2 checks passed
@bcspragu bcspragu deleted the brandon/event-grid-send branch November 1, 2023 21:17
Copy link
Contributor

@gbdubs gbdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants