Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP 204 No Content for endpoints without response bodies #24

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

bcspragu
Copy link
Collaborator

This is more semantically accurate and generates the expected void response in the frontend client code, see ferdikoomen/openapi-typescript-codegen#607

Copy link
Contributor

@gbdubs gbdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bcspragu bcspragu merged commit bdc598c into main Sep 18, 2023
2 checks passed
@bcspragu bcspragu deleted the brandon/no-content branch September 18, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants