Fix error modal handling #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbdubs
approved these changes
Jan 24, 2024
frontend/app.vue
Outdated
| @@ -1,4 +1,5 @@ | |||
| <script setup lang="ts"> | |||
| import { isSilent } from '~/lib/error' | |||
There was a problem hiding this comment.
Lol not sure how I missed that the rest of the codebase does it that way, done
bcspragu
force-pushed
the
brandon/err2
branch
from
dff9f3d to
4a2e5cc
Compare
As discussed, this is an alternate approach to #174 for fixing #168. It handles errors directly in `withLoading` and `pactaClient`. The problem then is that both these functions return _something_, so you still have to throw and interrupt the flow of code (I originally tried just leaving hanging promises, but our linter informed me that's a really bad idea) Since we have to throw, we throw a sentinel so that anything further up the chain knows not to render another dialog. I tested it in a few different cases and confirmed it does what we expect.
bcspragu
force-pushed
the
brandon/err2
branch
from
4a2e5cc to
3829d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this is an alternate approach to #174 for fixing #168. It handles errors directly in
withLoadingandpactaClient. The problem then is that both these functions return something, so you still have to throw and interrupt the flow of code (I originally tried just leaving hanging promises, but our linter informed me that's a really bad idea)Since we have to throw, we throw a sentinel so that anything further up the chain knows not to render another dialog.
I tested it in a few different cases and confirmed it does what we expect.