Fail CI runs on lint #176
Merged
Fail CI runs on lint #176
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In shell, `;` means "run the next thing regardless", so when `eslint` failed, we just ran stylelint regardless, and that was the exit code that GH Actions saw Using `&&` short-circuits when something fails, so if eslint fails now, GH Actions will also fail
gbdubs
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In shell,
;means "run the next thing regardless", so wheneslintfailed, we just ran stylelint regardless, and that was the exit code that GH Actions sawUsing
&&short-circuits when something fails, so if eslint fails now, GH Actions will also fail