Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about Duplicate Analyses, Allow Holdings Date to be Cleared #162

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Jan 22, 2024

  • Adds a warning when a user tries to run an analysis that is duplicative, a "nice to have" from the SOW.
  • While working on this I realized there was an error in how HoldingsDate was populated + thus whether or not it could be cleared. I've fixed that bug (which required many code changes) alongside this small feature.

@gbdubs gbdubs requested a review from bcspragu January 22, 2024 19:42
@gbdubs gbdubs merged commit 1449b1b into main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants