Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive Deletes #159

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Recursive Deletes #159

merged 1 commit into from
Jan 22, 2024

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Jan 22, 2024

  • Deletes analysis based on a Portfolio if the portfolio gets deleted (satisfying the constraint we've implicitly encoded through the FKC's on the portfolio_snapshot's fields).
  • Does the same for portfolio_group and initiative (though we can't yet run analyses based on these)
  • Because this changes the signatures to return []pacta.BlobURI on deletes, adds blob deletion code to the API.

NOTE: I haven't been able to validate through running locally that the deletes for PGs or Initaitives work when this is run because we don't have the ability to run portfolio group or initaitive based analyeses yet.

@gbdubs gbdubs requested a review from bcspragu January 22, 2024 17:00
db/sqldb/initiative.go Show resolved Hide resolved
db/sqldb/initiative.go Show resolved Hide resolved
db/sqldb/owner.go Show resolved Hide resolved
@gbdubs gbdubs merged commit c263946 into main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants