Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Buttons: View, Download + Run #149

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Jan 19, 2024

  • Adds a shared set of buttons for viewing + dowloading a report. The download button uses jsZip which was the library with broadest usage that I found. Happy to supplant it for another. The zip downloads nicely, and can be opened (though the relative URLs leave the assets broken :( )
  • Adds a runAnalysis button, with the goal being to use a standard hint in a few places to encourage folks to run audits, and to allow them to stay in the same place and visit the report once created. Works decently well, but ran into Enable Duplicate Reports by changing Blob URI scheme #148 , which will need independent attention
  • Populates Snapshots in Analyses so we can see what they refer to.
  • Populates ownerId on analysis so we can grey-out analyses that the user doesn't have access to (note this is not load-bearing authz, just used to prevent users from the frustration of an err message)
  • Updates getMaybeMe to return back other info other than the user, in this case, the user's ownerId. This is more in line with what we do in AS, where the me call returns back announcements + personal tasks.
  • Fixes the external warning when navigating to view the report in browser
  • Updates the Metadata sections of list views to just be an always standard debug until we can figure out what RMI wants out of that.
  • Fixes the oapi spec's blob_id => blobId

@gbdubs gbdubs requested a review from bcspragu January 19, 2024 02:27
frontend/components/analysis/AccessButtons.vue Outdated Show resolved Hide resolved
frontend/components/analysis/AccessButtons.vue Outdated Show resolved Hide resolved
@gbdubs gbdubs enabled auto-merge (squash) January 20, 2024 18:34
@gbdubs gbdubs merged commit 5830d11 into main Jan 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants