Report Buttons: View, Download + Run #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsZip
which was the library with broadest usage that I found. Happy to supplant it for another. The zip downloads nicely, and can be opened (though the relative URLs leave the assets broken :( )runAnalysis
button, with the goal being to use a standard hint in a few places to encourage folks to run audits, and to allow them to stay in the same place and visit the report once created. Works decently well, but ran into Enable Duplicate Reports by changing Blob URI scheme #148 , which will need independent attentiongetMaybeMe
to return back other info other than theuser
, in this case, the user'sownerId
. This is more in line with what we do in AS, where theme
call returns back announcements + personal tasks.external
warning when navigating to view the report in browserMetadata
sections of list views to just be analways
standard debug until we can figure out what RMI wants out of that.blob_id
=>blobId