Barebones Analysis Display + Audit Logs #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcspragu
approved these changes
Jan 18, 2024
Comment on lines
+118
to
+122
| } else { | ||
| s.logger.Info("poorly constructed analysis id", zap.String("path", string(aID)), zap.Error(err)) | ||
| http.Error(w, http.StatusText(http.StatusNotFound), http.StatusNotFound) | ||
| return | ||
| } |
There was a problem hiding this comment.
Is this a real issue we expect to happen? Generally I don't like to treat the entity ID prefixes as "load-bearing", they're simply a useful debugging/sanity checking tool. What's wrong with using db.IsErrNotFound?
There was a problem hiding this comment.
Good question - I wanted to differentiate between them mostly for ease-of-debugging. There are some missing dependencies, and I'd like to distinguish in logs in such a way that we can alert about actual failures, and build in good filters for known missing deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my-datapage.viewbutton which allows a user to see the report, with a few failures.apiFileType enums