Addressses Review Comments

RMI-PACTA · Jan 22, 2024 · 8a6045f · 8a6045f
1 parent cf86524
commit 8a6045f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/frontend/components/standard/Nav.vue b/frontend/components/standard/Nav.vue
@@ -1,6 +1,5 @@
 <script setup lang="ts">
 import { type MenuItem } from 'primevue/menuitem'
-import type * as PrimeVueMenu from 'primevue/menu'
 
 const { t } = useI18n()
 const localePath = useLocalePath()

diff --git a/frontend/pages/audit-logs.vue b/frontend/pages/audit-logs.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { type AuditLogQuerySort, type AuditLogQueryWhere, type AuditLogQueryReq, AuditLogAction, AuditLogTargetType, AuditLogQuerySortBy, type AuditLog } from '@/openapi/generated/pacta'
 import { urlReactiveAuditLogQuery } from '@/lib/auditlogquery'
-import { type DataTableSortMeta, type DataTableFilterMeta } from 'primevue/datatable'
+import { type DataTableSortMeta } from 'primevue/datatable'
 import { FilterMatchMode } from 'primevue/api'
 
 const prefix = 'pages/audit-logs'
@@ -196,7 +196,7 @@ const allColumns: Column[] = [
     customBody: true,
     filterType: FilterType.EnumBased,
     enumValues: Object.values(AuditLogAction).map((a: AuditLogAction) => ({
-      label: `${a}`.replace('AuditLogAction', ''),
+      label: a.replace('AuditLogAction', ''),
       value: a,
     })).sort((a, b) => a.label.localeCompare(b.label)),
   },
@@ -231,7 +231,7 @@ const allColumns: Column[] = [
     sortBy: AuditLogQuerySortBy.AUDIT_LOG_QUERY_SORT_BY_PRIMARY_TARGET_TYPE,
     filterType: FilterType.EnumBased,
     enumValues: Object.values(AuditLogTargetType).map((a: AuditLogTargetType) => ({
-      label: `${a}`.replace('AuditLogTargetType', ''),
+      label: a.replace('AuditLogTargetType', ''),
       value: a,
     })).sort((a, b) => a.label.localeCompare(b.label)),
   },
@@ -439,9 +439,14 @@ const getTargetLink = (t: AuditLogTargetType, id: string): string => {
   return '#'
 }
 
-const columnControlOverlay = useState<{ toggle: (e: Event) => void }>(`${prefix}.columnControlOverlay`)
+const columnControlOverlay = ref<{ toggle: (e: Event) => void }>()
 const toggleColumnControl = (e: Event) => {
-  columnControlOverlay.value.toggle(e)
+  const c = columnControlOverlay.value
+  if (c) {
+    c.toggle(e)
+  } else {
+    console.warn('columnControlOverlay is not available')
+  }
 }
 
 const defaultAuditLogQuery = (): AuditLogQueryReq => {