Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bcspragu committed Jan 13, 2024
1 parent 0c1b96b commit 69a9def
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
8 changes: 7 additions & 1 deletion cmd/runner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ bazel run //scripts:run_server -- --use_azure_runner

### Creating a new docker image to run locally

When testing locally (e.g. without `--use_azure_runner`), you can build and tag a runner image locally and use that. To do that, run `bazel run //scripts:build_and_load_runner`
When developing the runner, you have two options:

* **Test against local Docker** - Run the server **without** the `--use_azure_runner`, which means async tasks will run locally, using `docker run ...`. To test local runner changes, you can build and tag a runner image locally with `bazel run //scripts:build_and_load_runner`.
* After running the script, the updated runner will immediately be available, no need to restart the server.
* This is the option you'll want to use most of the time.
* **Test against Azure Container Apps Jobs** - Run the server **with** the `--use_azure_runner`, which means async tasks will be run on Azure, created via the Azure API. To test changes here, you can build and tag a runner image locally with `bazel run //scripts:build_and_load_runner`, and then push it to Azure with `docker push rmisa.azurecr.io/runner:latest`
* You generally won't need to use this option unless you're testing something very specific about the runner's integration with Azure, as the runner code is identical whether run locally or on Azure.

### Cleaning up old runner containers

Expand Down
3 changes: 2 additions & 1 deletion frontend/i18n.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ export default defineI18nConfig(() => ({
// Consider using process.env.NODE_ENV == 'prod', etc.
const fn = vm?.appContext.app.$nuxt.$missingTranslations.handleMissingTranslation
if (fn) {
// const callable = fn as (locale: string, key: string) => void
fn(locale, key)
} else {
console.warn(`No handleMissingTranslation function found, can't handle ${locale} ${key}`)
}
},
}))

0 comments on commit 69a9def

Please sign in to comment.