Review Comments

azure/azblob/azblob.go

@@ -101,16 +101,6 @@ func (c *Client) DeleteBlob(ctx context.Context, uri string) error {
 	return nil
 }
 
-func (c *Client) DeleteBlobs(ctx context.Context, uris []string) error {
-	// Implement parallel delete if slow - not prematurely optimizing.
-	for i, uri := range uris {
-		if err := c.DeleteBlob(ctx, uri); err != nil {
-			return fmt.Errorf("deleting blob %d/%d: %w", i, len(uris), err)
-		}
-	}
-	return nil
-}
-
 // SignedUploadURL returns a URL that is allowed to upload to the given URI.
 // See https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/storage/[email protected]/sas#example-package-UserDelegationSAS
 func (c *Client) SignedUploadURL(ctx context.Context, uri string) (string, error) {

cmd/server/pactasrv/BUILD.bazel

@@ -8,6 +8,7 @@ go_library(
         "initiative_user_relationship.go",
         "pacta_version.go",
         "pactasrv.go",
+        "parallel.go",
         "portfolio.go",
         "upload.go",
         "user.go",

cmd/server/pactasrv/pactasrv.go

@@ -87,7 +87,7 @@ type Blob interface {
 	SignedUploadURL(ctx context.Context, uri string) (string, error)
 	// For downloading reports
 	SignedDownloadURL(ctx context.Context, uri string) (string, error)
-	DeleteBlobs(ctx context.Context, uris []string) error
+	DeleteBlob(ctx context.Context, uri string) error
 }
 
 type Server struct {

cmd/server/pactasrv/parallel.go

@@ -0,0 +1,24 @@
+package pactasrv
+
+import (
+	"context"
+	"fmt"
+)
+
+type blobDeleter interface {
+	DeleteBlob(ctx context.Context, uri string) error
+}
+
+func deleteBlobs(ctx context.Context, bd blobDeleter, uris []string) error {
+	// Implement parallel delete if slow - not prematurely optimizing.
+	for i, uri := range uris {
+		if err := bd.DeleteBlob(ctx, uri); err != nil {
+			return fmt.Errorf("deleting blob %d/%d: %w", i, len(uris), err)
+		}
+	}
+	return nil
+}
+
+func (s *Server) deleteBlobs(ctx context.Context, uris []string) error {
+	return deleteBlobs(ctx, s.Blob, uris)
+}