Skip to content

Commit

Permalink
Addresses Review Comments, Adds i18n where missing
Browse files Browse the repository at this point in the history
  • Loading branch information
gbdubs committed Jan 24, 2024
1 parent 04113b4 commit 32a9888
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 9 deletions.
3 changes: 3 additions & 0 deletions frontend/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,9 @@
},
"pages/upload": {
"Input User Guide": "Input User Guide",
"Sample CSV": "Sample CSV",
"Paragraph1": "This is a page where you can upload portfolios to test out the PACTA platform.",
"Paragraph2": "Input files are expected to be structured as CSVs with an expected set of header rows. To learn more, check out the Input User Guide or download a sample CSV.",
"Add File(s)": "Add File(s)",
"Add More File(s)": "Add More File(s)",
"Cleaning Up": "Cleaning Up",
Expand Down
5 changes: 3 additions & 2 deletions frontend/pages/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const tt = (s: string) => t(`pages/index.${s}`)
icon="pi pi-arrow-right"
icon-pos="right"
class="max-w-30rem"
to="/upload"
:to="localePath('/upload')"
/>
</div>
</div>
Expand All @@ -82,7 +82,8 @@ const tt = (s: string) => t(`pages/index.${s}`)
<p>
{{ tt('Section4Paragraph1') }}
<LinkButton
to="pacta.rmi.org"
to="https://pacta.rmi.org"
external
class="p-button-xs align-self-center py-0 ml-2 p-button-outlined"
:label="tt('Section4CTA')"
icon="pi pi-arrow-right"
Expand Down
27 changes: 20 additions & 7 deletions frontend/pages/upload.vue
Original file line number Diff line number Diff line change
Expand Up @@ -294,17 +294,30 @@ const cleanUpIncompleteUploads = async () => {
<template>
<StandardContent>
<TitleBar title="Upload Portfolios" />
<!-- TODO(#80) Finalize this copy -->
<p>
This is a page where you can upload portfolios to test out the PACTA platform.
{{ tt('Paragraph1') }}
</p>
<p>
Input files are expected to be structred as CSVs with an expected set of header rows.
To learn more, check out the <a
:href="localePath('/input-guide')"
target="_blank"
>{{ tt('Input User Guide') }}</a>, or download the <a href="/samples/sample-1.csv">sample CSV</a>.
{{ tt('Paragraph2') }}
</p>
<div class="flex gap-1">
<LinkButton
:to="localePath('/input-guide')"
new-tab
class="p-button-xs p-button-outlined"
icon="pi pi-external-link"
icon-pos="right"

Check warning on line 309 in frontend/pages/upload.vue

View workflow job for this annotation

GitHub Actions / frontend

Expected indentation of 8 spaces but found 6 spaces
:label="tt('Input User Guide')"

Check warning on line 310 in frontend/pages/upload.vue

View workflow job for this annotation

GitHub Actions / frontend

Expected indentation of 8 spaces but found 6 spaces
/>
<LinkButton
to="/samples/sample-1.csv"
new-tab
class="p-button-xs p-button-outlined"
icon="pi pi-download"
icon-pos="right"

Check warning on line 317 in frontend/pages/upload.vue

View workflow job for this annotation

GitHub Actions / frontend

Expected indentation of 8 spaces but found 6 spaces
:label="tt('Sample CSV')"

Check warning on line 318 in frontend/pages/upload.vue

View workflow job for this annotation

GitHub Actions / frontend

Expected indentation of 8 spaces but found 6 spaces
/>
</div>
<FormField
label="Portfolio Files"
class="w-full mb-0"
Expand Down

0 comments on commit 32a9888

Please sign in to comment.