Skip to content

Commit

Permalink
Fail CI runs on lint
Browse files Browse the repository at this point in the history
In shell, `;` means "run the next thing regardless", so when `eslint` failed, we just ran stylelint regardless, and that was the exit code that GH Actions saw

Using `&&` short-circuits when something fails, so if eslint fails now, GH Actions will also fail
  • Loading branch information
bcspragu committed Jan 24, 2024
1 parent b4a5e27 commit 2458174
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"build:dev": "NITRO_PRESET=azure nuxi build --dotenv=envs/env.dev",
"deploy:dev": "npm run build:dev && swa deploy pacta-frontend-dev --no-use-keychain --app-name pacta-frontend-dev --resource-group rmi-pacta-dev --env Production",
"typecheck": "nuxi typecheck",
"lint": "eslint --cache --ext .js,.vue,.ts ./; stylelint --cache '**/*.{vue,css,scss}' ;",
"lint:fix": "eslint --fix --ext .js,.vue,.ts ./; stylelint '**/*.{vue,css,scss}' --fix",
"lint": "eslint --cache --ext .js,.vue,.ts ./ && stylelint --cache '**/*.{vue,css,scss}'",
"lint:fix": "eslint --fix --ext .js,.vue,.ts ./ && stylelint '**/*.{vue,css,scss}' --fix",
"generate:openapi:pacta": "openapi --input ../openapi/pacta.yaml --output ./openapi/generated/pacta/ --name PACTAClient",
"generate:openapi:user": "openapi --input ../openapi/user.yaml --output ./openapi/generated/user/ --name UserClient",
"generate:openapi": "npm run generate:openapi:pacta && npm run generate:openapi:user"
Expand Down

0 comments on commit 2458174

Please sign in to comment.