Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json schema #106

Merged
merged 21 commits into from
Sep 3, 2024
Merged

Json schema #106

merged 21 commits into from
Sep 3, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Aug 21, 2024

Add actions to render JSON Schema docs, and check if docs have been rendered

See READMEs for more details

See it in action:
Failing: https://github.com/RMI-PACTA/workflow.pacta/actions/runs/10487116315/job/29046793851#step:3:146
Passing (after rendered docs have been added): https://github.com/RMI-PACTA/workflow.pacta/actions/runs/10487632582/job/29048400774?pr=94#step:7:1

@AlexAxthelm AlexAxthelm marked this pull request as ready for review August 21, 2024 09:55
@AlexAxthelm AlexAxthelm requested a review from jdhoffa August 21, 2024 09:55
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos, and one comment/ question on the config.json implementation

actions/json-schema/check-docs/README.md Outdated Show resolved Hide resolved
actions/json-schema/render-docs/Dockerfile Outdated Show resolved Hide resolved
actions/json-schema/render-docs/action.yml Outdated Show resolved Hide resolved
actions/json-schema/render-docs/config.json Outdated Show resolved Hide resolved
@AlexAxthelm AlexAxthelm requested a review from jdhoffa August 27, 2024 13:03
@AlexAxthelm AlexAxthelm merged commit bfaa1e4 into main Sep 3, 2024
@AlexAxthelm AlexAxthelm deleted the json-schema branch September 3, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants