FWT-11 #2 hallelujah effect sensor #1
Conversation
|
will need to redo as I require a GPIO IRQ Handler |
mjmagee991
changed the title
…work in isolation
There was a problem hiding this comment.
Looks pretty good, just a few changes. Please remove the cmake-build-debug directory and make sure your build directory is set to 'build' in the CMAKE options. Also please update the README to describe the purpose of this repository. Also include the target device and the name of the main board target (REV3-WSS).
There was a problem hiding this comment.
A lot of nitpicks, but the overall structure is pretty good.
Also, be sure to test this thoroughly. This driver is written assuming that we'll be able to poll the GPIO fast enough not to have issues, but that's not a great assumption to be making. If this isn't working, we may have to investigate an interrupt-based solution
…or' into feature/ol2764RIT/hallEffectSensor
…or' into feature/ol2764RIT/hallEffectSensor
| enum class WheelSpeedState { | ||
| STOP, /** Wheel is not moving */ | ||
| INITIALIZING, /** Setting speed based on first reading */ | ||
| MAINTAIN, /** Wheel is spinning at a constant speed or speeding up */ |
There was a problem hiding this comment.
Could be constant, speeding up, or slowing down
| MAINTAIN, /** Wheel is spinning at a constant speed or speeding up */ | |
| MAINTAIN, /** Wheel is spinning */ |
| MAINTAIN, /** Wheel is spinning at a constant speed or speeding up */ | ||
| }; | ||
|
|
||
| /** Constructor (take a GPIO instance and the radius of the wheel) */ |
There was a problem hiding this comment.
Update this comment and make it match our normal standard
| uint32_t lastInterval; | ||
| /** Current state of the wheel */ | ||
| WheelSpeedState state; | ||
| /** Flag to check if the sensor is high */ |
There was a problem hiding this comment.
In your comments and variables, you should talk about the magnet being detected or not detected. If we get another hall effect sensor that's active high instead of low, we don't want to have to go through and update all the comments. The value of MAGNET_DETECTED_STATE should be the only way to know if the sensor is active high or low
| bool magnetDetected = false; | ||
| if (magnetReadLow && magnetInLastRead != magnetReadLow) { | ||
| magnetDetected = true; | ||
| } |
There was a problem hiding this comment.
This is entirely stylistic, but I would recommend this
| bool magnetDetected = false; | |
| if (magnetReadLow && magnetInLastRead != magnetReadLow) { | |
| magnetDetected = true; | |
| } | |
| const bool magnetDetected = magnetReadLow && !magnetInLastRead; |
| /* | ||
| * The speed of the wheel in revolutions per minute. | ||
| * lastInterval is the time that it takes for one full revolution of the wheel | ||
| * in milliseconds, so converting that to RPM is just dividing 60000 by lastInterval. | ||
| */ |
Created the very new hallSensor class
-Goes through a GPIO read and assigns the correct case
-returns time
-returns distance traveled and speed
Created main for WSS using hall effect sensors
-Created representation of WSS using two hall effect sensors for back and front wheels
-Allow can transmission of data for validation of proper functionality