Contributing Another New Open-source Project-Enabling Nuance #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not compile yet, I still have to fix BQ76952's canopen references NOTE: Some of the indexes of the BMS's CANopen dictionary may have changed, so the RPDOs for any boards that read from the BMS should be updated accordingly. I will do this once I get this class working.
Note: need to finish adding Todos and also comment out the same sort of stuff in BQSettingStorage.cpp. Other Note: doesn't compile because of the aforementioned BQSettingStorage issues.
mjmagee991
changed the title
AarC10
approved these changes
Mar 22, 2024
EatonWu
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded BMS CANopen
Disabled all SDOs