Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce noise on output #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reduce noise on output #113

wants to merge 1 commit into from

Conversation

iranzo
Copy link
Member

@iranzo iranzo commented Nov 10, 2022

Removes messages about oc debug (which almost any check includes) and reduces output when no specific cards are found and just report about the ones found

Fixes #112

@dcritch
Copy link
Contributor

dcritch commented Nov 15, 2022

@iranzo Looks like your previous PR created a conflict?

@iranzo
Copy link
Member Author

iranzo commented Nov 15, 2022

@iranzo Looks like your previous PR created a conflict?

Rebased!

@ptrnull
Copy link
Contributor

ptrnull commented Nov 16, 2022

What is the goal of this PR? The message are placed in purpose to inform the user what is going on. If we remove them the user will have a false feeling that nothing is ongoing and that the tool is not doing anything. @iranzo can you clarify?

@github-actions github-actions bot added size/S and removed size/M labels Nov 16, 2022
@iranzo
Copy link
Member Author

iranzo commented Nov 18, 2022

What is the goal of this PR? The message are placed in purpose to inform the user what is going on. If we remove them the user will have a false feeling that nothing is ongoing and that the tool is not doing anything. @iranzo can you clarify?

As there are checks and a wrapper that executes them, the messages about 'running XXX' should be in the wrapper and not the check itself to give a bit of consistency.

Also, if you put the message in the wrapper and not in the test, you can filter out for the actual test output and not the 'decoration' like 'please wait, etc' which is irrelevant if you're running this periodically.

I would advise towards having just output when there are errors or problems

@iranzo iranzo mentioned this pull request Feb 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrnull ptrnull Awaiting requested review from ptrnull

@dcritch dcritch Awaiting requested review from dcritch

Assignees
No one assigned
Labels
checks info size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup some of the codes
3 participants
@iranzo @dcritch @ptrnull