Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI and HTML report not consistent #131

Open
ribua opened this issue Feb 14, 2023 · 4 comments
Open

CLI and HTML report not consistent #131

ribua opened this issue Feb 14, 2023 · 4 comments
Assignees

Comments

@ribua
Copy link
Contributor

ribua commented Feb 14, 2023

Hi ,

Reporting issues for checks that are working from CLI and report indicates the following messages.

./openshift-checks.sh -s checks/zombies
Using system:serviceaccount:ribu-test:sa-kubeconfig context
Collecting zombie processes... (using oc debug, it can take a while)
No issues found

The above when run via HTML report just indicates the below information

image

The page doesn;t refresh with the new information or final results.

Ribu

@iranzo
Copy link
Member

iranzo commented Feb 14, 2023

It reports the status as 'OK' in the HTML interface. The 'No issues found' is equivalent to the 'OK' as reported by the CLI interface:

  if [ ${errors} -gt 0 ]; then
    die "${RED}Total issues found: ${errors}${NOCOLOR}"
  else
    msg "${GREEN}No issues found${NOCOLOR}"
  fi

@iranzo
Copy link
Member

iranzo commented Feb 14, 2023

@ribua Try and paste the output of risu.py -l -i zombies -v here

@iranzo iranzo self-assigned this Feb 14, 2023
@gitkent
Copy link

gitkent commented Feb 16, 2023

Hi all, I am working with @ribua for this issue. Please find below output from risu.py -l -i zombies -v

❯ risu.py -l -i zombies -v
INFO:risu:Storing output on file reports/osc.json

[l%%%l]=[]=

# checksroot/nagios/checks/zombies: okay

@iranzo
Copy link
Member

iranzo commented Feb 16, 2023

Hi @gitkent

So that confirms what I was mentioning, the difference in the reporting comes from the openshift-checks.sh wrapper. Graphical or risu console output of 'okay' is the equivalent of the wrapper saying 'No issues found'.

There was a PR for making the openshift-checks.sh more silent at #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants