-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump R version #302
bump R version #302
Conversation
Coverage too small is direct reason why appveyor failed. |
Removing
branch worked well. |
@mlampros Do you have any idea? |
Yeah, now R installation process is OK. Coverage is small means that R-package fails and doesn't work, only stub file Speaking to |
@fukatani |
I want to test appveyor with previous version of
it still forces downloading of new version:
Does anyone know how to install UPD: Got it work by removing |
Unpinning Python version, since upstream issue has been fixed. |
I'm sorry to both of you I just saw the issue,
require(devtools)
install_version("reticulate", version = "1.12.0", repos = "https://cran.rstudio.com")
It probably has to do with the installation file. I can't give an advice for the appveyor ci because as you already know there is an open issue with a 'help-wanted' badge for the windows installation. |
Nothing had been changed from our side since the last successful CI run, so I guess we need to investigate which package update leaded to current fail. |
I might be in place to make the execution of the tests and loading of the R package more verbose, by that I mean to modify the package.R file and the skip_test_if_no_module by adding if-else statements, so that messages are printed to the console if either Python (3.7 in this case) or any of the loaded Python modules is not detectable. That way we will be at least in place to understand if it has to do with the Python version or with the RGF modules. |
@mlampros I think both of your ideas are good! Feel free to contribute! |
I think that I understood what the problem of the failed build is. default {$env:MINICONDA = "C:\Miniconda37"} however the R-package is tested with Miniconda36 PYTHON_VERSION: 3.6
TASK: R_PACKAGE May I ask why the R package is tested on Python 3.6 when the default Python version is 3.7? This is a quite sensitive case for the reticulate package and there are numerous issues related with the default version when using Python from within R. reticulate::py_discover_config() could give us the answer to the issue. |
I remember it was done due to issues with early Python 3.7 version on Windows. I think we can update the version now.
It's default only for us. There is no any Miniconda paths in PATH variable initially. So I don't think it's the real root cause. I want to understand what changed since our last successful run 2 months ago. I'm going to use RDP connection to Appveyor to investigate this when have more free time. |
Closing in favor of #305. |
Refer to #300 (comment).