Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deterministic contract creation. Add convenient RGB20 contract builder #139

Merged
merged 20 commits into from
Feb 4, 2024

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added enhancement New feature or request refactoring Code refactoring labels Jan 28, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jan 28, 2024
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice. The builder looks like it might be able to replace some of our code. @crisdut can have a look. If it's good, maybe we can get one for RGB21 also.

ACK.

@dr-orlovsky
Copy link
Member Author

@cryptoquick yeah, and this is how it simplifies the code: https://github.com/RGB-WG/rgb-schemata/pull/25/files#diff-4df006067551c6856f6cc2101216b0bc8ab7626eafaee07992d6eeac7ffb13d3L33-L70

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@dr-orlovsky dr-orlovsky merged commit 57df659 into master Feb 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Code refactoring
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants