ifaces: use correct fungible builder type

[TheWaWaR]

Since Terminal.seals is a SmallXxx collection, so the seal quantity may reach up to 65535, then the corresponding builder should allow seal quantity up to 65535.

pub struct Terminal {
    pub seals: SmallOrdSet<TerminalSeal>,
    pub tx: Option<Tx>,
}

It's not a protocol change, if you wish I can port this fix to v0.10 branch.

[dr-orlovsky]

You are right that we should allow up to 2^16 assignments in the operation builder, but this is not related to terminal seals, and is instead related to the number of assignments inside the genesis/state transition, which is 2^16.

Terminal seals can be collected from multiple state transition, thus limit there is unrelated to this one.

Anyway, thank you for spotting that. Can you please also update data, rights and attach in the same way?

Thank you for finding this!

[TheWaWaR]

I can only find rights(commented)/fungible/data, but not attach.

pub struct OperationBuilder<Seal: ExposedSeal> {
    // TODO: use references instead of owned values
    schema: SubSchema,
    iface: Iface,
    iimpl: IfaceImpl,
    asset_tags: TinyOrdMap<AssignmentType, AssetTag>,

    global: GlobalState,
    // rights: TinyOrdMap<AssignmentType, Confined<HashSet<BuilderSeal<Seal>>, 1, U8>>,
    fungible:
        TinyOrdMap<AssignmentType, Confined<HashMap<BuilderSeal<Seal>, RevealedValue>, 1, U8>>,
    data: TinyOrdMap<AssignmentType, Confined<HashMap<BuilderSeal<Seal>, RevealedData>, 1, U8>>,
    // TODO: add attachments
    // TODO: add valencies
}

[dr-orlovsky]

ACK d428466

Thank you!