Skip to content

Commit

Permalink
SERXIONE-2617: WPEProcess crash with TTS::TTSManager::interrupted (rd…
Browse files Browse the repository at this point in the history
…kcentral#4526)

Reason for change: During Destruction Process of TTSSpeaker m_callback is set to NULL and it accessed by GstremerThreadFuc which leads to crash
Signed-off-by: Chockalingam Murugan <[email protected]>
Test Procedure: Sanity Testing in apps
Priority: P1
Risks: None

Co-authored-by: Ramasamy Thalavay Pillai <[email protected]>
  • Loading branch information
cmurug728 and ramasat committed Oct 20, 2023
1 parent f193463 commit 25f31dc
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
6 changes: 5 additions & 1 deletion TextToSpeech/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ All notable changes to this RDK Service will be documented in this file.

* For more details, refer to [versioning](https://github.com/rdkcentral/rdkservices#versioning) section under Main README.

## [1.0.16] - 2023-10-18
# [1.0.17] - 2023-10-20
### Fixed
- Fixed crash with TTS::TTSManager::interrupted signature

# [1.0.16] - 2023-10-18
### Changed
- Added missing TTS Event Logs

Expand Down
2 changes: 1 addition & 1 deletion TextToSpeech/TextToSpeech.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

#define API_VERSION_NUMBER_MAJOR 1
#define API_VERSION_NUMBER_MINOR 0
#define API_VERSION_NUMBER_PATCH 16
#define API_VERSION_NUMBER_PATCH 17
#define API_VERSION_NUMBER 1

namespace WPEFramework {
Expand Down
3 changes: 2 additions & 1 deletion TextToSpeech/impl/TTSManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ TTSManager::TTSManager(TTSEventCallback *callback) :

TTSManager::~TTSManager() {
TTSLOG_TRACE("TTSManager::~TTSManager");
m_callback = NULL;
TTSEventCallback dummyCallback;
m_callback = &dummyCallback;

// Clear Speaker Instance
if(m_speaker) {
Expand Down

0 comments on commit 25f31dc

Please sign in to comment.