Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify GeckoEidechse-Headhunter-0.0.4 #42

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GeckoEidechse
Copy link
Member

Headhunter v0.0.4

Did I read the whole README file and understood all of its content?

YES

Did I update verified-mods.json with my new mod's information?

YES

Has a previous version of my mod been previously verified?

NO

Mod description

A reupload of the Headhunter gamemode as a standalone mod

Thunderstore link

https://thunderstore.io/c/northstar/p/GeckoEidechse/Headhunter/

@GeckoEidechse GeckoEidechse added the verification request Request for verification label Aug 14, 2024
@GeckoEidechse
Copy link
Member Author

Ok it seems CI fails cause we consider the tag not to have the leading v in the version number which feels a bit weird. Putting this on pause for now.

@Alystrasz
Copy link
Contributor

Alystrasz commented Aug 26, 2024

Ok it seems CI fails cause we consider the tag not to have the leading v in the version number which feels a bit weird. Putting this on pause for now.

Shall we look for both {tag} and v{tag} then?

EDIT: the reason we consider tags don't have any leading v is because we use the raw "Version" field from the manifesto, which is used as-is by the game client to determine whether a mod can be downloaded; alternatively, we could enforce said format (= without leading v) by adding a mention in the README, or add a tag member in manifesto to each mod version entry (first option is easier to apply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verification request Request for verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants