Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify x3Karma-HotPotato-1.0.0 #24

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

x3Karma
Copy link
Contributor

@x3Karma x3Karma commented Jan 19, 2024

HotPotato v1.0.0

Did I read the whole README file and understood all of its content?

YES

Did I update verified-mods.json with my new mod's information?

YES

Has a previous version of my mod been previously verified?

NO

Mod description

A new gamemode for Northstar Launcher featuring a classical twist on the original Hot Potato gamemodes.

Thunderstore link

https://northstar.thunderstore.io/package/x3Karma/HotPotato/

@x3Karma x3Karma changed the title Add HotPotato into verified-mods.json Verify HotPotato Jan 19, 2024
@x3Karma
Copy link
Contributor Author

x3Karma commented Jan 19, 2024

I forgot whether if its supposed to be HotPotato or HotBattery (given that its been 9 months since I last looked at it, and the original repository is 2 years ago), I could always just fix the localization to HotPotato in post.

@GeckoEidechse GeckoEidechse changed the title Verify HotPotato Verify x3Karma-HotPotato-1.0.0 Jan 19, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we do not have the tooling yet to automate checking the repo against the Thunderstore mod, I only checked the Thunderstore mod (which is our ground source of truth anyway).

I checked there was no obvious malicious behaviour or files included in the zip. There's no use of "dangerous" 1 functions.

Note that there's still a left-over example.nut. As this doesn't appear to be referenced in the mod.json this doesn't have any impact but you might still wanna consider pushing another update that removes it.

As usual, verification does not ensure correctness, only non-malicious behaviour. Correctness is responsibility of the mod author.

With that said, in terms of verifying for no malicious behaviour this is good to go :D

Footnotes

  1. e.g.: Safe I/O stuff and SquirrelHTTP. "dangerous" is a bit too much maybe. Under the assumption that the native implementations are correct and secure, there's nothing dangerous here. However it's always recommended to use more of a Swiss cheese approach and also operate a bit under the assumption that a layer can fail.

@GeckoEidechse GeckoEidechse merged commit 41599c9 into R2Northstar:master Jan 19, 2024
3 checks passed
@GeckoEidechse GeckoEidechse added the verification request Request for verification label Jan 19, 2024
@x3Karma x3Karma deleted the patch-1 branch January 21, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verification request Request for verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants