Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to PlayerAssist callback #729

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

NoCatt
Copy link
Contributor

@NoCatt NoCatt commented Sep 30, 2023

Adds a function to the player killed callback that is just a copy paste of how we handle assists everywhere else

yes this PR is untested :>

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 30, 2023
@ASpoonPlaysGames
Copy link
Contributor

Very weird whitespace stuff going on here lol

Will properly review once I can tell what actually changed

@ASpoonPlaysGames ASpoonPlaysGames added the waiting on changes by author Waiting on PR author to implement the suggested changes label Oct 20, 2023
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@Zanieon
Copy link
Contributor

Zanieon commented Jul 7, 2024

Any updates on this to solve conflicts? There's some other stuff that requires changing as well before merging.

@GeckoEidechse

This comment was marked as outdated.

@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Aug 14, 2024
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Aug 15, 2024

Aight, I reverted all the unrelated whitespace changes via f824608 to clean up the diff

(omfg we desperately need a Squirrel formatter so this doesn't keep happening and doesn't need to be done by hand...)

@GeckoEidechse GeckoEidechse removed the waiting on changes by author Waiting on PR author to implement the suggested changes label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants