Better Better Server Browser (somewhat) #645

AlphaGaming7780 · 2023-05-31T16:56:34Z

Better Server Browser

The goal of this PR, as the name suggests, is to revamp the server browser.

I recommend merging this PR before mine: #624

Interesting thing to know:

The scroll bar (for the server details) automatically hides and appears as needed.
The search entry automatically resizes its width to fit the text inside the label.
Before:

After :
Now, if you left-click on the Server description or required mod, you can scroll up and down to navigate through the displayed text, if it's possible.

Need an opinion:

Should I add a menu to bookmark servers, since bookmarking is planned? It might be better.
Should I save the filters applied by the player, so that they are preserved when the game is relaunched?
Which menu should appear first when a player selects a server: its description or the required mods?
Should I add a setting in the mod settings to let the player choose which menu they want to see first (description/required mods)?

TODO

Disabled mods are not counted as missing. To reproduce this bug, disable a mod that is required by a server. It will still appear in the installed mods list. [1.1.0]
Add a scroll bar to the description + required mod list. [1.2.0] + [1.2.1]
Add favourites ? No, Can't save data. But do I have to make the UI for this ? No one answered so marked as finished
I still need to clean up the code by removing all the comments I added or unnecessary thing, if you agree. [1.3.0]
Fixed the search label width [1.4.0]

Video and other stuff

Below, you will find a video showcasing the changes made. The video is made using V1.1.0

titanfall2-20230531-20384810_C8j9Umhp.mp4

You can also download this mod (V1.7.0), which does the same thing. (https://northstar.thunderstore.io/package/TritonSupreme/BetterServerBrowser/)

to the description + mods label of the serevr details panel

+ Removed unused code part + other tiny things

Fixed a bug with the map selection menu scroll bar

Now, if you left-click on the Server description or required mod, you can scroll up and down to navigate through the displayed text, if it's possible.

F1F7Y · 2023-06-26T12:28:54Z

Personally I would find it better if you PRed your fixes separately

Also I remember @uniboi said he was also working on improvements to the server browser

AlphaGaming7780 · 2023-06-26T23:24:06Z

The only changes I made that are not auditions are:

Enlarging the "Join" button to occupy the entire width of the menu containing server details.
Making the text input for searching servers by name resize based on the size of the adjacent label.

I don't think these two small changes deserve a pull request on their own, as these two issues only seem to occur (I believe) for non-English localizations.

GeckoEidechse · 2023-06-26T23:41:53Z

Northstar.Client/mod.json

-			"DefaultValue": "0"
-		},
+        {
+            "Name": "filter_map",


Unintentional indentation change? Like only default value was changed but more stuff shows up in diff

Is this an issue that I need to fix, or is it just a remark ?
And no, I don't see why GitHub considers every line as replaced instead of modified.
Also, my indentations are done with tabs and a size of 4.

That's an issue that should be resolved. Forgot I could just use web version of vscode to check diff. Anyway looks likes it caused by replacing tabs with spaces:

Okay It's fixed

Northstar.Client/mod/resource/ui/menus/panels/sb_map_grid.res

Northstar.Client/mod/resource/ui/menus/sb_map_select.menu

GeckoEidechse · 2023-06-26T23:46:35Z

I don't think these two small changes deserve a pull request on their own, as these two issues only seem to occur (I believe) for non-English localizations.

The thing with making multiple smaller PRs is that it means that these smaller changes are not blocked by some issue in the other parts of the code. As splitting up a PR is kinda annoying as the person submitting it, my personal approach when I submit a bigger PR is to have one big PR with all the changes and then making new smaller PRs with some of those changes that can be added independently.

Then when the smaller changes are merged, I update the original big PR to be up-to-date with main and once a bunch of the smaller changes are merged, the diff of the big PR gets smaller and smaller until there's only one logical change left ^^

This way smaller stuff gets merged faster but I still got one big "batteries included" PR that showcases all of the changes.

fix unintentional indentation change.

AlphaGaming7780 · 2023-06-27T16:31:58Z

I can split my PR into smaller PRs if you insist, but let me know what you want me to PR.
Here's a list of the changes and their dependencies:

Change the map select button and method
Change the Gamemode select button and method
Change the size of the join Button
Make the Search entry auto resize to fit the label next to it
UI reorganization

New Filters
New Server details Panels

The 2 buttons + text + scrollbar

fix unintentional indentation change 2.

Northstar.Client/mod/scripts/vscripts/ui/menu_sb_mode_select.nut

I'm not sure what this file is for. I had added that line of code at the beginning because `MenuMapSelect_Init()` was there, and I was using this menu as a reference to create the map select menu for the server browser. However, after testing, I found that the menu works perfectly fine without that line, so I decided to remove it.

uniboi · 2023-06-27T17:37:59Z

Also I remember @uniboi said he was also working on improvements to the server browser

yes I'm working on a complete rewrite of the server browser

F1F7Y · 2023-07-09T20:12:32Z

I can split my PR into smaller PRs if you insist, but let me know what you want me to PR. Here's a list of the changes and their dependencies:

Each fix/feature should preferably be its own PR

GeckoEidechse · 2023-07-09T20:15:01Z

I can split my PR into smaller PRs if you insist, but let me know what you want me to PR. Here's a list of the changes and their dependencies:

Each fix/feature should preferably be its own PR

The easiest way to do this btw, is to just branch off of this branch, then remove all the changes except the one you want to PR, PR that, and then revert merge conflicts on this PR here once the other one is merged.

Rinse and repeat (and maybe even parallelise) and by the end everything should be merged ^^

AlphaGaming7780 · 2023-07-10T19:50:25Z

I have been on vacation for about 2 weeks and I have 1 week left, so I am unable to work on this at the moment.

GeckoEidechse · 2024-06-08T13:55:18Z

Thanks for @Zanieon for bumping this PR and putting it back on my radar <3

Anyway, to increase the chances of this being merged I highly recommend making smaller PRs for some of the fixes. This way we can get parts of this merged faster than having to go through the whole thing all at once which tends to scare people away from reviewing/testing ^^"

Zanieon · 2024-11-27T12:34:45Z

Drafting this until PR actually go anywhere (conflicts).

AlphaGaming7780 added 6 commits May 31, 2023 17:39

V1.0.0

f2f8eb3

Fix disabled mods appear as installed

753becb

[V1.2.0] Add the scroll bar

7ec09db

to the description + mods label of the serevr details panel

[1.2.1]Fixe the description cut off

b427ce7

+ Removed unused code part + other tiny things

[V1.3.0] Clean the code

42435a8

[1.4.0] The search entry automatically resizes

a737db7

F1F7Y changed the title ~~Better Server Browser~~ Better Better Server Browser (somewhat) Jun 2, 2023

AlphaGaming7780 added 3 commits June 4, 2023 15:21

Unnecessary stuff removed

a79aeed

[V1.6.0] Fixe a bug

0fbe73e

Fixed a bug with the map selection menu scroll bar

Fix the scroll functionality for the Server details

5e8f579

Now, if you left-click on the Server description or required mod, you can scroll up and down to navigate through the displayed text, if it's possible.

GeckoEidechse reviewed Jun 26, 2023

View reviewed changes

AlphaGaming7780 added 2 commits June 27, 2023 17:58

Merge branch 'R2Northstar:main' into BetterServerBrowser

0cdc01f

Update mod.json

e9a5ac2

fix unintentional indentation change.

AlphaGaming7780 added 3 commits June 27, 2023 18:36

Update mod.json

ae197dc

fix unintentional indentation change 2.

Update sb_map_grid_button.res

77a6118

Removed an unnecessary file

21a5110

AlphaGaming7780 commented Jun 27, 2023

View reviewed changes

Northstar.Client/mod/scripts/vscripts/ui/menu_sb_mode_select.nut Outdated Show resolved Hide resolved

Merge branch 'main' into BetterServerBrowser

1a03a12

AlphaGaming7780 added 3 commits July 10, 2023 21:50

Merge branch 'main' into BetterServerBrowser

c0f7edb

Merge branch 'main' into BetterServerBrowser

fdd20a7

Merge branch 'main' into BetterServerBrowser

88adba9

ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code feedback wanted Feedback is wanted whether the changes by this PR are desired labels Sep 2, 2023

AlphaGaming7780 and others added 5 commits September 2, 2023 18:54

Merge branch 'main' into BetterServerBrowser

427f9dd

Merge branch 'main' into BetterServerBrowser

a3314a5

Update menu_sb_mode_select.nut

670ad30

Merge branch 'main' into BetterServerBrowser

0198d5c

Merge branch 'main' into BetterServerBrowser

ea013cb

github-actions bot added merge conflicts Blocked by merge conflicts, waiting on the author to resolve and removed merge conflicts Blocked by merge conflicts, waiting on the author to resolve labels Jul 29, 2024

Merge branch 'main' into BetterServerBrowser

892c57a

github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Nov 21, 2024

Zanieon marked this pull request as draft November 27, 2024 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better Better Server Browser (somewhat) #645

Better Better Server Browser (somewhat) #645

AlphaGaming7780 commented May 31, 2023 •

edited

Loading

F1F7Y commented Jun 26, 2023

AlphaGaming7780 commented Jun 26, 2023

GeckoEidechse Jun 26, 2023

AlphaGaming7780 Jun 27, 2023

GeckoEidechse Jun 27, 2023

AlphaGaming7780 Jun 27, 2023

GeckoEidechse commented Jun 26, 2023 •

edited

Loading

AlphaGaming7780 commented Jun 27, 2023 •

edited

Loading

uniboi commented Jun 27, 2023

F1F7Y commented Jul 9, 2023

GeckoEidechse commented Jul 9, 2023

AlphaGaming7780 commented Jul 10, 2023

GeckoEidechse commented Jun 8, 2024

Zanieon commented Nov 27, 2024

Better Better Server Browser (somewhat) #645

Are you sure you want to change the base?

Better Better Server Browser (somewhat) #645

Conversation

AlphaGaming7780 commented May 31, 2023 • edited Loading

Better Server Browser

Interesting thing to know:

Need an opinion:

TODO

Video and other stuff

F1F7Y commented Jun 26, 2023

AlphaGaming7780 commented Jun 26, 2023

GeckoEidechse Jun 26, 2023

Choose a reason for hiding this comment

AlphaGaming7780 Jun 27, 2023

Choose a reason for hiding this comment

GeckoEidechse Jun 27, 2023

Choose a reason for hiding this comment

AlphaGaming7780 Jun 27, 2023

Choose a reason for hiding this comment

GeckoEidechse commented Jun 26, 2023 • edited Loading

AlphaGaming7780 commented Jun 27, 2023 • edited Loading

uniboi commented Jun 27, 2023

F1F7Y commented Jul 9, 2023

GeckoEidechse commented Jul 9, 2023

AlphaGaming7780 commented Jul 10, 2023

GeckoEidechse commented Jun 8, 2024

Zanieon commented Nov 27, 2024

AlphaGaming7780 commented May 31, 2023 •

edited

Loading

GeckoEidechse commented Jun 26, 2023 •

edited

Loading

AlphaGaming7780 commented Jun 27, 2023 •

edited

Loading