-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Mod information #826
Merged
RoyalBlue1
merged 11 commits into
R2Northstar:main
from
Alystrasz:refactor/mod-information
Nov 21, 2024
Merged
refactor: Mod information #826
RoyalBlue1
merged 11 commits into
R2Northstar:main
from
Alystrasz:refactor/mod-information
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
Changes from the PR still need to be tested
needs code review
Changes from PR still need to be reviewed in code
labels
Nov 1, 2024
This was referenced Nov 1, 2024
Alystrasz
added
the
depends on another PR
Blocked until the PR it depends on is merged
label
Nov 12, 2024
RoyalBlue1
requested changes
Nov 19, 2024
RoyalBlue1
requested changes
Nov 20, 2024
RoyalBlue1
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes have been implemented and code looks good
Alystrasz
removed
the
needs code review
Changes from PR still need to be reviewed in code
label
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
depends on another PR
Blocked until the PR it depends on is merged
needs testing
Changes from the PR still need to be tested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to retrieve mod information from launcher, Squirrel VM must summon methods such as
NSGetModDescriptionByModName
,NSGetModDownloadLinkByModName
,NSGetModLoadPriority
etc, which all loop over the list of mods until they find the correct one (using mod name as key), which is highly ineffective: this means we need as many iterations over mods list as we need information about the mod.To solve this problem, this PR introduces a
NSGetModsInformation
, which exposes all mod information to Squirrel VM at once, using a newModInfo
structure.This is meant to make reviewing #758 and R2Northstar/NorthstarMods#824 easier.
(I highly discourage you to look at the github diff, which is fucked up, and suggest rather looking at the changes commit per commit!)
Don't merge without mods counterpart: R2Northstar/NorthstarMods#899
Testing