Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Remove unused SourceInterface class #816

Merged
merged 2 commits into from
Oct 6, 2024
Merged

core: Remove unused SourceInterface class #816

merged 2 commits into from
Oct 6, 2024

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Sep 6, 2024

Code review:

Removes unused SourceInterface class, moves InterfaceStatus enum to tier1.h.

Testing:

If it compiles it works as this was unused. In terms of InterfaceStatus iirc source doesnt use the second argument of CreateInterface and you should still check for nullptr so even if i did break it it shouldnt affect release.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 6, 2024
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, not much to say

@ASpoonPlaysGames ASpoonPlaysGames added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Sep 7, 2024
Alystrasz
Alystrasz approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, played an entire game with no issues.
(once again, the simple fact that CI build finishes successfully validates this PR)

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Oct 6, 2024
@GeckoEidechse GeckoEidechse merged commit 8a29c5b into R2Northstar:main Oct 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@F1F7Y @Alystrasz @ASpoonPlaysGames @GeckoEidechse