Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(?): Allow Vanilla Compatibility Mode to Auth #688

Closed
wants to merge 2 commits into from

Conversation

VITALISED
Copy link

This PR makes some small changes to allow -vanilla users to authenticate to MS, because it is really stupid that they cannot frankly. (This is a counterpart to: R2Northstar/NorthstarMods#800)

@itscynxx
Copy link
Contributor

itscynxx commented Apr 7, 2024

For the record, as the "main" person pushing vanilla support at the moment, I don't think we have the dev strength to really keep up with genuinely adding vanilla and northstar compat side by side. I do technically have a local set of core mods that does this, however this is confined to my machine and I'm unsure if it actually brings about any issues

There are a lot of risks this introduces, and there are about 4 people in the world that care about fixing the issues it could cause

This pr also has unrelated changes in it. Why remove key invalidation? Does it break vanilla? If it does, then make it only run while not on vanilla?

@VITALISED
Copy link
Author

I think the thing with the key invalidation stuff was because I was faffing around with switching from Northstar->Vanilla and it wasn't getting any new tickets from Origin, probably need to tidy that up

@GeckoEidechse
Copy link
Member

Pretty sure not allowing vanilla mode to auth with Atlas was on purpose for a reason. cc @ASpoonPlaysGames ig ^^

@ASpoonPlaysGames
Copy link
Contributor

ASpoonPlaysGames commented Apr 8, 2024

The entire reason behind not allowing them to auth is because in vanilla compatibility mode we also disable various things that we wouldn't want disabled on untrustworthy servers. Very intentional to not allow people using -vanilla to play on northstar servers.

@VITALISED VITALISED closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants