Fix incorrect help string text #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help strings for `ns_server_name` and `ns_server_desc` were swapped. Co-authored-by: BobTheBob <[email protected]>
GeckoEidechse
added
needs testing
taskinoz
approved these changes
Oct 10, 2023
H0L0theBard
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help strings for
ns_server_nameandns_server_descwere swapped.PR only changes 2 strings.
Spliced out from #408 (which can only be merged on version gate due to breaking change).
I did NOT test this due to being on a Linux device without Titanfall2 access right now.
Testing instructions:
Simply open console and check if help text is now correct for
ns_server_nameandns_server_descwith this PR.