Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiscordRPC to plugins v4 #17

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Conversation

catornot
Copy link
Member

@catornot catornot commented Jan 20, 2024

:)
100% rust now

maybe I will actually move everything into the plugin soon

@GeckoEidechse GeckoEidechse changed the title Update DiscordRpc to plugins v4 Update DiscordRPC to plugins v4 Jan 20, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing together with R2Northstar/NorthstarLauncher#615

Launched the game and joined a PvP and a Parkour server each while checking that Discord activity would update accordingly.

src/discord.rs Outdated Show resolved Hide resolved
@catornot catornot requested a review from uniboi January 21, 2024 19:40
Copy link

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, really just an update to a newer rrplug commit

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything from reviews has been addressed. This should be good to merge now ^^

@GeckoEidechse GeckoEidechse merged commit 2f0c0e6 into R2Northstar:main Feb 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants