Added KiwiIRC as WebView component #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added corresponding page, loads local HTML that contains an iframe with KiwiIRC. Used WebChromeClient to open links from chat.
KiwiIRC-nextclient is much more adapted to phones. I don't know how to roemove that big doggo though.
|
Can't test, but code looks fine in theory. I'd recommend heading to IRC and contact some staff for merging this. It's a new feature so the codebase could use a version bump along with an update on the play store by someone with the credentials. |
|
I wrote a complete new app (with this and much MUCH more). You can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it could be interesting to have access to R/a/dio IRC directly through the app. The website is a bit unpractical, and sometimes people just want to have a single app, not a second IRC client.
I added a 4th page with WebView displaying KiwiIRC-nextclient. (The "nextclient" version is more adapted for smartphones).
The theme used is "dark" to go with the rest of the app. There's probably room for improvement with tweaked theme or particular settings, but it works decently as it is currently.
App tested on various virtual devices (screen ranging from 800x480 to 1920x1080), on a Moto G5 Plus (Android 8.1, 5.2" screen 1920x1080), and on a Xiaomi Redmi 6A (Android 9, 5.5" 1440x720).
You can try the APK : https://shelter.mahoro-net.org/~yattoz/r-a-d.io-kiwiirc.apk