[16.0][IMP] delivery_postlogistics: Print return label in status Ready #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuocDuong1306
force-pushed
the
16.0-Print-return-label-in-status-ready
branch
from
8f7ec47 to
8b70b5d
Compare
QuocDuong1306
changed the title
| @@ -156,3 +156,15 @@ def verify_credentials(self): | |||
| }, | |||
| } | |||
| return message | |||
|
|
|||
| def _compute_can_generate_return(self): | |||
| res =super(DeliveryCarrier, self)._compute_can_generate_return() | |||
There was a problem hiding this comment.
Suggested change
| res =super(DeliveryCarrier, self)._compute_can_generate_return() | |
| res = super(DeliveryCarrier, self)._compute_can_generate_return() |
There was a problem hiding this comment.
Hi @nilshamerlinck , I'm done
QuocDuong1306
force-pushed
the
16.0-Print-return-label-in-status-ready
branch
2 times, most recently
from
abdf66f to
dc74f33
Compare
QuocDuong1306
force-pushed
the
16.0-Print-return-label-in-status-ready
branch
from
dc74f33 to
52fdf22
Compare
nilshamerlinck
suggested changes
Jul 11, 2023
| _inherit = "stock.return.picking" | ||
|
|
||
| def _create_returns(self): | ||
| res = super(ReturnPicking, self)._create_returns() |
There was a problem hiding this comment.
Suggested change
| res = super(ReturnPicking, self)._create_returns() | |
| new_picking, pick_type_id = super(ReturnPicking, self)._create_returns() |
|
|
||
| def _create_returns(self): | ||
| res = super(ReturnPicking, self)._create_returns() | ||
| record = self.env['stock.picking'].browse(res[0]) |
There was a problem hiding this comment.
Suggested change
| record = self.env['stock.picking'].browse(res[0]) | |
| picking = self.env['stock.picking'].browse(new_picking) |
Comment on lines
9
to
10
| if record: | ||
| record.carrier_id = self.picking_id.carrier_id and self.picking_id.carrier_id.id or False |
There was a problem hiding this comment.
Suggested change
| if record: | |
| record.carrier_id = self.picking_id.carrier_id and self.picking_id.carrier_id.id or False | |
| picking.write({"carrier_id": self.picking_id.carrier_id.id}) |
| record = self.env['stock.picking'].browse(res[0]) | ||
| if record: | ||
| record.carrier_id = self.picking_id.carrier_id and self.picking_id.carrier_id.id or False | ||
| return res |
There was a problem hiding this comment.
Suggested change
| return res | |
| return new_picking, pick_type_id |
| class ReturnPicking(models.TransientModel): | ||
| _inherit = "stock.return.picking" | ||
|
|
||
| def _create_returns(self): |
There was a problem hiding this comment.
this will impact all returns
can you add a condition on self.picking_id.delivery_type == "postlogistics"
QuocDuong1306
force-pushed
the
16.0-Print-return-label-in-status-ready
branch
from
52fdf22 to
2070e89
Compare
|
Hi @nilshamerlinck , I updated |
nilshamerlinck
suggested changes
Jul 11, 2023
delivery_postlogistics/__init__.py
Outdated
| @@ -1,2 +1,3 @@ | |||
| from . import models | |||
| from . import postlogistics | |||
| from . import wizard | |||
QuocDuong1306
force-pushed
the
16.0-Print-return-label-in-status-ready
branch
from
2070e89 to
3b9214f
Compare
|
Sorry @nilshamerlinck , could you review again? |
QuocDuong1306
force-pushed
the
16.0-Print-return-label-in-status-ready
branch
from
3b9214f to
8e09b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.