Resolve issue #36 - php 7.3 compatiblity #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the compatibility issue with PHP 7.3 issue sunra/php-simple-html-dom-parser#64 and Quinn-Interactive#36
Update for class namespace to resolve PHP 7.3 compatibility
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 33.48% 33.48%
Complexity 176 176
=========================================
Files 16 16
Lines 451 451
=========================================
Hits 151 151
Misses 300 300
Continue to review full report at Codecov.
|
|
Thanks for this @obj63mc, I see I'm going to go ahead and merge this in and release after some testing/fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated your dependency for php-simple-html-dom-parser with one that will work with PHP 7.3. Please refer to issue #36 and sunra/php-simple-html-dom-parser#64 (comment)