-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental support for using Mojmap as a runtime #469
Open
EnnuiL
wants to merge
11
commits into
QuiltMC:develop
Choose a base branch
from
EnnuiL:wip/mojmap-runtime
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d0970dd
Begin progress on Mojmap as runtime
EnnuiL 706f83c
Clarify that the QuiltLauncher is the source of truth on the runtime …
TheGlitch76 74f7498
Work for Oro
TheGlitch76 bc9130c
It works! Still needs lots of cleaning...
TheGlitch76 e472632
Get things in a working state
TheGlitch76 4a542ad
Clean up
TheGlitch76 319edc9
Hide intermediate mappings once again
TheGlitch76 c88d640
Final fixes(?)
TheGlitch76 c0a8d22
Fix tests
TheGlitch76 9d8d4db
License header
TheGlitch76 48533b3
Fix OOM in junit
TheGlitch76 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -285,7 +285,8 @@ private V1ModMetadataImpl readFields(JsonLoaderValue.ObjectImpl root) { | |||||
@Nullable | ||||||
JsonLoaderValue intermediateMappingsValue = quiltLoader.get(QLKeys.INTERMEDIATE_MAPPINGS); | ||||||
|
||||||
String[] supported_mappings = { "org.quiltmc:hashed", "net.fabricmc:intermediary" }; | ||||||
// TODO: "mojang" for mojmap breaks spec; it is just temporary for now because its experimental | ||||||
String[] supported_mappings = { "org.quiltmc:hashed", "net.fabricmc:intermediary", "mojang" }; | ||||||
String mappings = "org.quiltmc:hashed"; | ||||||
|
||||||
if (intermediateMappingsValue != null) { | ||||||
|
@@ -309,6 +310,10 @@ private V1ModMetadataImpl readFields(JsonLoaderValue.ObjectImpl root) { | |||||
throw new ParseException("Oh no! This version of Quilt Loader doesn't support hashed mappings, please update Quilt Loader to use this mod."); | ||||||
} | ||||||
|
||||||
if (mappings.equals("mojang") && !QuiltLoader.getMappingResolver().getNamespaces().contains("mojang")) { | ||||||
throw new ParseException("Oh no! This version of Quilt Loader doesn't support Mojang mappings, please update Quilt Loader to use this mod."); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This copy-pastey comment doesn't make sense here compared to the Hashed Mojmap one; how about:
Suggested change
(potential remedies to this are to be determined once uhhhh, we figure out a good way to provide mojmap) |
||||||
} | ||||||
|
||||||
builder.intermediateMappings = mappings; | ||||||
|
||||||
// Metadata | ||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"net.minecraft:mojang"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glitch says this is temporary, but well? I know how permanent placeholders can be like!
Anyway,
net.minecraft:mojang
makes sense for dev purposes, but Loom usesnet.minecraft:mappings
, which makes sense but is confusing! (what is Minecraft mappings? I've heard of Mojang!)So, considering this and Mojang's official standards? Maybe we should go with
com.mojang:mappings
?