Fixes forking for workers. Should not corrupt pg connection anymore. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To achieve that, all logging actions are moved out to the parent process, so child process only does the workload and marshals it back to parent process. Forked workers should NOT re-use parent connection (sanity check added). The code makes use of exit!(0) command, that triggers fast exit from a forked process, so postgres does not close the forked connection. Adds specs for forked workers success/failure, mixed workers, connection reuse exception.
This was referenced May 14, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution for #207 forking
To achieve correct forking, all SQL-queries are moved out to the parent process, so child process only does the workload and marshals result back to parent process. Forked workers should NOT re-use parent connection (sanity check added).
The code makes use of exit!(0) command, that triggers fast exit from a forked process, so postgres does not have a chance to close the connection.
Adds specs for forked workers success/failure, mixed workers, connection reuse exception.